Review Request: Keep placeholder text visible when empty and focused
Laszlo Papp
lpapp at kde.org
Wed Dec 12 18:40:22 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107600/#review23365
-----------------------------------------------------------
There was a similar, but discarded patch for this: https://git.reviewboard.kde.org/r/104895/
- Laszlo Papp
On Dec. 12, 2012, 5:11 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107600/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2012, 5:11 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch keeps the place holder text visible when a TextField is focused. This is useful for situations where a text field is focused at startup. We use it in Homerun for the search field.
>
> I filed a similar review-request for kdelibs KLineEdit and KTextEdit: https://git.reviewboard.kde.org/r/107678/
>
>
> Diffs
> -----
>
> plasma/declarativeimports/plasmacomponents/qml/TextField.qml d19e7d8
>
> Diff: http://git.reviewboard.kde.org/r/107600/diff/
>
>
> Testing
> -------
>
> Ran widgetgallery with the patch code, as can be seen in attached screenshot.
>
>
> Screenshots
> -----------
>
> TextField with placeholder from Widget Gallery
> http://git.reviewboard.kde.org/r/107600/s/872/
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121212/ace6e6c3/attachment-0001.html>
More information about the Plasma-devel
mailing list