Review Request: Keep placeholder text visible when empty and focused

[Kevin Krammer]

> On Dec. 9, 2012, 1:01 p.m., Marco Martin wrote:
> > in different platforms i seen both behaviors, hiding the text immediately or only when something is written.
> > 
> > i am fine with this change, but i think the qwidget behavior (only ktextedit i think?) should be made the same

QLineEdit also clears the placeholder text when being focused, at least it does so on my system (could be dependent on style, using Oxygen here)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107600/#review23194
-----------------------------------------------------------


On Dec. 5, 2012, 4:11 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107600/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2012, 4:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch keeps the place holder text visible when a TextField is focused. This is useful for situations where a text field is focused at startup. We use it in Homerun for the search field.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/TextField.qml d19e7d8 
> 
> Diff: http://git.reviewboard.kde.org/r/107600/diff/
> 
> 
> Testing
> -------
> 
> Ran widgetgallery with the patch code, as can be seen in attached screenshot.
> 
> 
> Screenshots
> -----------
> 
> TextField with placeholder from Widget Gallery
>   http://git.reviewboard.kde.org/r/107600/s/872/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121209/f8661b49/attachment.html>