Review Request: Make sure ksmserver ignores excluded apps when saving session

[Jekyll Wu]

> On Nov. 11, 2012, 11:13 a.m., Aaron J. Seigo wrote:
> > ksmserver/server.cpp, line 939
> > <http://git.reviewboard.kde.org/r/107276/diff/1/?file=94565#file94565line939>
> >
> >     why not check for both program and filename? that should then catch 1, 2 and 4, no?
> >     
> >     excludeApps could also be pre-processed to include both long paths and filenames which would then allow catching all 4 variations.
> >     
> >     probably the reason this was written to only catch 1 and 4, however, was in case there were binaries of the same name in different paths that should be treated differently (allowing differentiation by full path)..
> >     
> >     Lubos will certainly have more insight on this, however.

> probably the reason this was written to only catch 1 and 4, however, was in case there were binaries of the same name in different paths that should be treated differently (allowing differentiation by full path)..

I think that is a valid case, but I also think it is rare. I prefer to first fix this more common problem with a simple patch, and wait to see how many users will notice and complain this rare case not working any more.


- Jekyll


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107276/#review21816
-----------------------------------------------------------


On Dec. 9, 2012, 7:50 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107276/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2012, 7:50 a.m.)
> 
> 
> Review request for kdelibs, Plasma and Luboš Luňák.
> 
> 
> Description
> -------
> 
> It is easy to understand why the existing code (usually) fails: 
> 
>   * Users are most likely to just specify short names, like "dolphin,gwenview,okular,rekonq", instead of "/usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq"
> 
>  * When ksmserver saves the session, it usually gets the full names, like "/usr/bin/dolphin", unless you have started that dolphin instance by typing "dolphin" exactly in a shell. 
> 
> 
> So there are four possible combinations :
> 
>   1). config uses short name, runtime gets short name (this guy starts everything from konsole, never using kio/krun)
>   2). config uses short name, runtime gets long name (I think this is the most common one)
>   3). config uses long name, runtime gets short name 
>   4). config uses long name, runtime gets long name (I guess some users use this combination because they find only that way works after trying various workaround...)
> 
> The existing code works with 1) and 4), the patch now works  with 1), 2) and 4) . I don't know whether it make senses to support all combinations .
> 
> 
>  
> 
> 
> This addresses bug 242760.
>     http://bugs.kde.org/show_bug.cgi?id=242760
> 
> 
> Diffs
> -----
> 
>   ksmserver/server.cpp a65b35a 
> 
> Diff: http://git.reviewboard.kde.org/r/107276/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121209/923d9530/attachment.html>