Review Request: Change Battery Percentage step of battery plasmoid

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107612/
-----------------------------------------------------------

(Updated Dec. 6, 2012, 7:04 p.m.)


Review request for Plasma, Marco Martin and Viranch Mehta.


Changes
-------

change the Fill20 icon to show under 20, to align with KDE default "low battery" setting.


Description
-------

Current battery plasmoid icon is very confusing when showing the percentage.

Currently,
96-100 -> looks like 100
81-95->looks like 80 (looks werid)
50-80->looks like 60 (looks werid)
20->49->looks like 40
10->19->looks like 20

When people see the icon shows as 60, they will expect that whey have lost nearly 40 percent, but actually 70-80 is also covered in this range.

And range doesn't split evenly is also a problem.
This patch change it to
90-100 looks like 100
70-89 looks like 80
50-69 looks like 60
30-49 looks like 40
10-29 looks like 20

Which IMHO is much better for visual.


Diffs (updated)
-----

  plasma/generic/applets/batterymonitor/contents/ui/BatteryIcon.qml cfb50df 

Diff: http://git.reviewboard.kde.org/r/107612/diff/


Testing
-------

No problem.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121206/fcd2de2e/attachment-0001.html>