Review Request: [rssnow] Revert the commit of merging left & right arrows into one

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107557/#review22932
-----------------------------------------------------------


.. or one could actually fix the code to load the correct svg.

the reason for the merge is obvious -> fewer svg files to open and parse. looks like the code using these arrows wasn't.

this will eventually get replaced with a QML version in any case.

- Aaron J. Seigo


On Dec. 2, 2012, 9:16 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107557/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2012, 9:16 p.m.)
> 
> 
> Review request for Plasma and Giorgos Tsiapaliokas.
> 
> 
> Description
> -------
> 
> There is good analyses in https://bugs.kde.org/show_bug.cgi?id=299516#c8 .
> 
> I really don't understand the rationale behind merging left arrow and right arrow into one. So I just ask for reverting commit 39f506cbb10b08f4c6f8e17048deae9da87812b3.
> 
> 
> This addresses bug 299516.
>     http://bugs.kde.org/show_bug.cgi?id=299516
> 
> 
> Diffs
> -----
> 
>   applets/rssnow/CMakeLists.txt 72be160 
>   applets/rssnow/arrows.svgz 9816b5a4408faaa0ba3dfc4c64c877bcee0a9337 
>   applets/rssnow/left.svgz PRE-CREATION 
>   applets/rssnow/right.svgz PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107557/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121203/8f2d966a/attachment.html>