QJSON a mandatory dependency to kde-workspaces?

[Martin Gräßlin]

On Friday 31 August 2012 20:24:25 Marco Gulino wrote:
> Thanks, it helped :)
> I just pushed on master, you can see the commit here:
> http://commits.kde.org/kde-workspace/56e9cf6e7a305caba2a38630109c0486dc1b9cd
> e
Instead of adding the define manually, you could have defined it in kde-
workspace/config-workspace.h.cmake through a #cmakedefine and just include 
config-workspace.h in you c++ file

Cheers
Martin
> 
> Cheers
> Marco
> 
> On Fri, Aug 31, 2012 at 9:01 AM, Martin Gräßlin <mgraesslin at kde.org> wrote:
> > On Friday 31 August 2012 08:48:20 Marco Gulino wrote:
> > > My fault, sorry... I just forgot about that additional dependency. I
> > 
> > think
> > 
> > > I'll be able to fix it today or tomorrow, by simply disabling chrome
> > > support when QJSON is not found.
> > > Small problem: there is no builtin  CMake script for QJSON, there's one
> > > around that works quite fine, however, I've been using it for other
> > 
> > project.
> > 
> > > Should I add this script to kde-workspace? where exactly?
> > 
> > Yes I think it is needed. I just wanted to move the check and run into an
> > issue becauase qjson_FOUND is not set.
> > 
> > I stop then my work on it as it's better to just exclude the Chrome
> > support.
> > My current patch to kde-workspace is attached, maybe it's a good starting
> > point for you. The FindQJSON.cmake file should go to cmake/modules.
> > 
> > Thanks for taking care of it
> > 
> > Martin
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120831/5a7c0b41/attachment.sig>