QJSON a mandatory dependency to kde-workspaces?

Martin Gräßlin mgraesslin at kde.org
Thu Aug 30 19:53:30 UTC 2012


Hi all,

since 8f0f84d9575812ee1832d7fabb2c8ee1a9058112 kde-workspace depends on QJSON. 
In plasma/generic/runners/bookmarks/CMakeLists.txt there is the following 
check:
find_package(QJSON REQUIRED)

unfortunately the macro_log_feature is not used, so instead of getting a nice 
summary of what is missing one has to search for something like [1].

Now fixing this is easy, but before doing so, I wanted to check whether it is 
really intended to have QJSON as a hard requirement for kde-workspace.

To me this looks like an optional dependency and if not present the bookmarks 
runner is just excluded.

Opinions?

Cheers
Martin

[1] http://paste.kde.org/541982
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120830/0ba14df4/attachment.sig>


More information about the Plasma-devel mailing list