Review Request: Weather Forecast QML port

Luis Gabriel Lima lampih at gmail.com
Thu Aug 30 01:53:29 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106225/
-----------------------------------------------------------

(Updated Aug. 30, 2012, 1:53 a.m.)


Review request for Plasma and Marco Martin.


Changes
-------

- Removed webkit linking from CMakeList
- Renamed dataUpdated() signal to modelUpdated()
- Fixed FiveDaysView (using opacity instead of alpha channel, removed mixed code inside the color assingment block)


Description
-------

This patch is part of the work done in my GSoC 2012 project.


Diffs (updated)
-----

  applets/weather/CMakeLists.txt 4ae9c6f 
  applets/weather/package/contents/ui/DetailsView.qml PRE-CREATION 
  applets/weather/package/contents/ui/FiveDaysView.qml PRE-CREATION 
  applets/weather/package/contents/ui/Notice.qml PRE-CREATION 
  applets/weather/package/contents/ui/NoticesView.qml PRE-CREATION 
  applets/weather/package/contents/ui/TopPanel.qml PRE-CREATION 
  applets/weather/package/contents/ui/Utils.js PRE-CREATION 
  applets/weather/package/contents/ui/WeatherListView.qml PRE-CREATION 
  applets/weather/package/contents/ui/main.qml PRE-CREATION 
  applets/weather/package/metadata.desktop PRE-CREATION 
  applets/weather/weatherapplet.h a7e7f8d 
  applets/weather/weatherapplet.cpp 9fd3e5f 
  applets/weather/weatherdelegate.h 8a27f0d 
  applets/weather/weatherdelegate.cpp 1cd987b 
  applets/weather/weatherview.h f177501 
  applets/weather/weatherview.cpp 5234cd3 

Diff: http://git.reviewboard.kde.org/r/106225/diff/


Testing
-------

- Tested inside panels and floating on desktop
- Tested with various providers and locations


Screenshots
-----------


  http://git.reviewboard.kde.org/r/106225/s/696/

  http://git.reviewboard.kde.org/r/106225/s/698/

  http://git.reviewboard.kde.org/r/106225/s/699/

  http://git.reviewboard.kde.org/r/106225/s/700/


Thanks,

Luis Gabriel Lima

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120830/834167b2/attachment.html>


More information about the Plasma-devel mailing list