Review Request: Make it possible to have a QAbstractItemModel as a property

Commit Hook null at kde.org
Wed Aug 29 15:35:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106267/#review18254
-----------------------------------------------------------


This review has been submitted with commit 64b17ff1540ebc89c8117030a4c782e07bbbf322 by Aleix Pol to branch master.

- Commit Hook


On Aug. 29, 2012, 3:25 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106267/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 3:25 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch introduces QAbstractItemModel to QDeclarative when setting up the plasma core components.
> 
> This way we don't have to cast to the type ourselves and produce proper QML errors if the type is not correct.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/corebindingsplugin.cpp f08d8b3 
>   plasma/declarativeimports/core/datamodel.h cf82648 
>   plasma/declarativeimports/core/datamodel.cpp 00108b1 
> 
> Diff: http://git.reviewboard.kde.org/r/106267/diff/
> 
> 
> Testing
> -------
> 
> Plasma::SortFilterModel didn't stop working.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120829/b37f2913/attachment.html>


More information about the Plasma-devel mailing list