Review Request: LCD Weather Station QML port

[Luis Gabriel Lima]

> On Aug. 29, 2012, 12:22 a.m., Luis Gabriel Lima wrote:
> > applets/weatherstation/package/contents/ui/LCDDisplay.qml, line 74
> > <http://git.reviewboard.kde.org/r/106226/diff/1/?file=81359#file81359line74>
> >
> >     I still think we should keep as it is now to make the text color consistent with the lcd display color. Even if the theme changes, the lcd display will stay with the same color because it's an image.
> 
> Marco Martin wrote:
>     in this particular case both can end up broken: when the theme changes you don't know what color the background will be and if theme.textcolor will go well with it, or if #202020 will go...
>     
>     so as the least dangerous way i would do:
>     use theme.textColor when the background is off
>     use "#202020" when is enabled
>     
>     breaking is still very well possible, but perhaps in less situations

I agree. I'll change it and do the merge.


- Luis Gabriel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106226/#review18201
-----------------------------------------------------------


On Aug. 27, 2012, 3:52 p.m., Luis Gabriel Lima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106226/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 3:52 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch is part of the work done in my GSoC 2012 project and contains the new version of the LCD Weather Station plasmoid.
> 
> 
> Diffs
> -----
> 
>   applets/weatherstation/CMakeLists.txt 748de4a 
>   applets/weatherstation/lcd.svgz 7f5f3d3 
>   applets/weatherstation/lcd2.svgz PRE-CREATION 
>   applets/weatherstation/lcd_digits.svgz PRE-CREATION 
>   applets/weatherstation/package/contents/ui/LCDDigit.qml PRE-CREATION 
>   applets/weatherstation/package/contents/ui/LCDDisplay.qml PRE-CREATION 
>   applets/weatherstation/package/contents/ui/Wind.qml PRE-CREATION 
>   applets/weatherstation/package/contents/ui/main.qml PRE-CREATION 
>   applets/weatherstation/package/metadata.desktop PRE-CREATION 
>   applets/weatherstation/weather_icons.svgz PRE-CREATION 
>   applets/weatherstation/weatherstation.h 6d4ae24 
>   applets/weatherstation/weatherstation.cpp 8ada9c2 
>   applets/weatherstation/wind_arrows.svgz PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106226/diff/
> 
> 
> Testing
> -------
> 
> - Tested inside panels and floating on desktop
> - Tested with various providers and locations
> 
> 
> Screenshots
> -----------
> 
> LCD background
>   http://git.reviewboard.kde.org/r/106226/s/701/
> No background
>   http://git.reviewboard.kde.org/r/106226/s/702/
> 
> 
> Thanks,
> 
> Luis Gabriel Lima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120829/641076fb/attachment-0001.html>