Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/#review17927
-----------------------------------------------------------



konsole/konsolepreviewer.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14158>

    Would be useful if the user was told what to do about it (i.e. either give the name of the expected file, or explain where you can set the name (and what it should be).



mainwindow.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14155>

    I don't really like this deviation in behavior, mainly because I don't see a reason for it.
    
    I think the behaviour of opening the konsole from the previewer is not ideal anyway, since that's a very unusual way to trigger a change in the main UI. The issue you're trying to address here is in the previewer, and access to the console should be in the main UI anyway (i.e. menu entry, shortcut, and possibly toolbar action).



mainwindow.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14157>

    Seems like a toggle button (checkable) is needed here, instead of trying to come up with whacky new concepts of doing the exact same =).


- Sebastian Kügler


On Aug. 22, 2012, 9:34 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106118/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2012, 9:34 a.m.)
> 
> 
> Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and Giorgos Tsiapaliwkas.
> 
> 
> Description
> -------
> 
> Hello,
> 
> This patch is adding the konsolepreviewer support to the KWin Scripts.
> When the user, is pressing the "Execute" button, then the script is being called.
> Also on the toolbar, there is a new action with name "konsole". This action is visible only when we are inside to a KWin Script.
> All the other packages, have a previewer. So the "konsole" action is located inside the previewer.
> 
> 
> Diffs
> -----
> 
>   konsole/konsolepreviewer.h 8dd4369 
>   konsole/konsolepreviewer.cpp c4f9f8b 
>   main.cpp 298be51 
>   mainwindow.h 8005d26 
>   mainwindow.cpp b84da4a 
>   plasmateui.rc b51884d 
> 
> Diff: http://git.reviewboard.kde.org/r/106118/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> konsole
>   http://git.reviewboard.kde.org/r/106118/s/693/
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120823/b56bf28a/attachment.html>