Review Request: Make autohide panel do not intercept events in fullscreen app

Christoph Feck christoph at maxiom.de
Tue Aug 21 10:24:05 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/#review17799
-----------------------------------------------------------


If this "feature" is going to be implemented, it should be configurable. If you are only using a mouse (or stylus on a Tablet PC), then you would have no way to reach the panel in full-screen mode. The better solution would be if plasma developers would implement the much requested panel delays, and have it increased when in full-screen mode.

In a related note, I also find it odd that the auto-hide panel does not go above "Keep Above Others" windows, but that may be intended. An auto-hide panel is a temporary window like a menu, so it should not be covered by anything except other such menus.

- Christoph Feck


On Aug. 21, 2012, 10:06 a.m., Alexey Shmalko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106110/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2012, 10:06 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Make autohide panel do not intercept events in fullscreen app.
> 
> I changed PanelView::shouldHintHide() to return true if current active application is in fullscreen mode. So in fullscreen applications panel will be always hidden.
> 
> 
> This addresses bugs 297920 and 305497.
>     http://bugs.kde.org/show_bug.cgi?id=297920
>     http://bugs.kde.org/show_bug.cgi?id=305497
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/panelview.cpp 7713740 
> 
> Diff: http://git.reviewboard.kde.org/r/106110/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexey Shmalko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120821/e636fe9d/attachment.html>


More information about the Plasma-devel mailing list