Review Request: Make autohide panel do not intercept events in fullscreen app

Alexey Shmalko rasen.dev at gmail.com
Tue Aug 21 10:15:39 UTC 2012



> On Aug. 21, 2012, 4:22 a.m., Martin Gräßlin wrote:
> > I do not see a reason why the hidden panel should not be allowed to go above a fullscreen window. True it's not possible for the normal panel case, but hidden panel is kind of special.
> > 
> > Apart from that I think you modified the wrong place as it's only about the hint and you bound it with whether compositing is used.

I moved check for fullscreen application in another place.

Don't know how to make panel slide over fullscreen apps. If somebody points me in right direction to search, I'll try to do this.


- Alexey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/#review17790
-----------------------------------------------------------


On Aug. 21, 2012, 10:06 a.m., Alexey Shmalko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106110/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2012, 10:06 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Make autohide panel do not intercept events in fullscreen app.
> 
> I changed PanelView::shouldHintHide() to return true if current active application is in fullscreen mode. So in fullscreen applications panel will be always hidden.
> 
> 
> This addresses bugs 297920 and 305497.
>     http://bugs.kde.org/show_bug.cgi?id=297920
>     http://bugs.kde.org/show_bug.cgi?id=305497
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/panelview.cpp 7713740 
> 
> Diff: http://git.reviewboard.kde.org/r/106110/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexey Shmalko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120821/5911745f/attachment.html>


More information about the Plasma-devel mailing list