Review Request: digital clock widget - popup focus

[Greg T]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105933/
-----------------------------------------------------------

(Updated Aug. 20, 2012, 6:07 p.m.)


Review request for Plasma and John Layt.


Description
-------

For some reason for this widgt the option setPassivePopup is enabled (probably because you can't control it with keyboard anyways). Interestingly, the result is that the popup doesn't hide if you, for example, open the settings dialog. This behaviour is a bug and not consistent with all other popup widgets.

I suppose this fixes also https://bugs.kde.org/show_bug.cgi?id=221301

On the other hand, we could also try to fix that passive popup feature, if it's broken...I don't know.


This addresses bug 221301.
    http://bugs.kde.org/show_bug.cgi?id=221301


Diffs
-----

  plasma/generic/applets/digital-clock/clock.cpp 1331776 

Diff: http://git.reviewboard.kde.org/r/105933/diff/


Testing
-------


Thanks,

Greg T

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120820/6bde6301/attachment.html>