Review Request: Fix for Bug 165792 - Allow multirow panels

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105932/#review17652
-----------------------------------------------------------


I'm quite on the fence with this.
while in theory makes sense being able to stack panels, it's a thing quite hard to get reliable, i just see too many problems with it. at least some conditions in the behavior should be satisfied:
* should still be possible to position two or more panels on the same line, given they don't overlap
* move and resize controls in the panel controller should continue to work reliably
* if two panels are stacked, any change of height of the bottom panel should cause a correct repositioning of the top panel
* how does one decide what panel stays at the bottom and what panel gets stacked? must be easy to switch them
* if two panels are on the same line because there is enough room, and one of the two resizes (by the user or spontaneously) the panels should be relayouted in two lines, with a consistent and reproducible decision of who stays on top and who stays on bottom
* all the described behavior shouldn't break for more than two lines


plasma/desktop/shell/panelview.cpp
<http://git.reviewboard.kde.org/r/105932/#comment13817>

    watch out for empty space and dead code


- Marco Martin


On Aug. 8, 2012, 4:19 p.m., Tobias Franz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105932/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 4:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> goes back to:
> https://bugs.kde.org/show_bug.cgi?id=165792
> 
> 
> This addresses bug 165792.
>     http://bugs.kde.org/show_bug.cgi?id=165792
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/panelview.cpp 50826a8 
> 
> Diff: http://git.reviewboard.kde.org/r/105932/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Franz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120818/a6236f23/attachment.html>