Review Request: Adding notify signals to FrameSvgItem
Mark Gaiser
markg85 at gmail.com
Sun Aug 12 13:05:57 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105987/#review17273
-----------------------------------------------------------
Just 2 minor issues for naming consistency.
plasma/declarativeimports/core/framesvgitem.h
<http://git.reviewboard.kde.org/r/105987/#comment13450>
Please change it to "enabledBordersChanged" to stay consistent with "setEnabledBorders" and "enabledBorders".
plasma/declarativeimports/core/framesvgitem.h
<http://git.reviewboard.kde.org/r/105987/#comment13451>
Please change it to "enabledBordersChanged" to stay consistent with "setEnabledBorders" and "enabledBorders".
- Mark Gaiser
On Aug. 11, 2012, 10:39 p.m., Luis Gabriel Lima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105987/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2012, 10:39 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> -------
>
> When we are using a QML element, we should be able to keep track of its property changes.
>
>
> Diffs
> -----
>
> plasma/declarativeimports/core/framesvgitem.h 7baf0cf
> plasma/declarativeimports/core/framesvgitem.cpp 02c9d19
>
> Diff: http://git.reviewboard.kde.org/r/105987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luis Gabriel Lima
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120812/38066c05/attachment.html>
More information about the Plasma-devel
mailing list