Review Request: Adding notify signals to FrameSvgItem

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105987/#review17265
-----------------------------------------------------------


As I understand it, the notify system is for attributes, where the object changes the value _itself_ (e.g. in response to user interaction), as opposed to where the application changed the value.

In that light, an imagePathChanged() would not make sense, because the path cannot change, except if the application changes it.

What am I missing?

- Christoph Feck


On Aug. 11, 2012, 10:39 p.m., Luis Gabriel Lima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105987/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2012, 10:39 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> When we are using a QML element, we should be able to keep track of its property changes.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/framesvgitem.h 7baf0cf 
>   plasma/declarativeimports/core/framesvgitem.cpp 02c9d19 
> 
> Diff: http://git.reviewboard.kde.org/r/105987/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luis Gabriel Lima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120812/11f1afc0/attachment-0001.html>