Review Request: Reduce the memory usage of the fileWatcher plasmoid

Simeon Bird bladud at gmail.com
Thu Aug 9 01:34:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105940/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

As noted in bug 256187, the fileWatcher plasmoid can use a lot of memory, particularly when first reading a file. 
This turns out to be because the whole file is added to the textDocument, instead of just the last few lines.

As a bonus, fix an (unreported) bug where if a line matched two filters, it could be printed twice.


This addresses bug 256187.
    http://bugs.kde.org/show_bug.cgi?id=256187


Diffs
-----

  applets/fileWatcher/fileWatcher.cpp fdf804c 

Diff: http://git.reviewboard.kde.org/r/105940/diff/


Testing
-------

Compiled, watched some (small and large) files, added and deleted lines from them. 


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120809/a67eb03d/attachment.html>


More information about the Plasma-devel mailing list