Review Request: small FIXME code cleanup in ui/notificationgroup.*

Marco Martin notmart at gmail.com
Tue Aug 7 12:48:46 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105900/#review17031
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Aug. 6, 2012, 9:59 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105900/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 9:59 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> The header contained a "FIXME" line which this patch solves.
> Also, an unneeded member variable was removed as it was only used locally
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/ui/notificationgroup.h 686442f 
>   plasma/generic/applets/notifications/ui/notificationgroup.cpp 7ea9355 
> 
> Diff: http://git.reviewboard.kde.org/r/105900/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120807/6a526fea/attachment.html>


More information about the Plasma-devel mailing list