Review Request: clean up auto-deletion timeout handling
Commit Hook
null at kde.org
Mon Aug 6 16:54:09 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105893/#review16984
-----------------------------------------------------------
This review has been submitted with commit e1110ac131fb234252c1b9687f5563d09a0b4ca0 by Martin Koller to branch master.
- Commit Hook
On Aug. 6, 2012, 11:01 a.m., Martin Koller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105893/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2012, 11:01 a.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> -------
>
> as discussed in private mail, the auto-deletion timer shall only be started from one single place, which is
> the notificationmanager, which starts the timer only if there is user activity on the desktop so that a notification
> which arrives while the user is not at his desk does not get deleted unseen.
> Also, the auto-deletion timeout is reduced to 5 minutes, as I think 20 minutes is much too long (Notifications should only
> provide temporary information for the user for things happening NOW. After some minutes the information is irrelevant).
> For information which is of critical importance, the application can use the urgency=2 which avoids the auto-deletion completely.
>
>
> Diffs
> -----
>
> plasma/generic/applets/notifications/core/notification.cpp 1e1350e
>
> Diff: http://git.reviewboard.kde.org/r/105893/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Koller
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120806/311a2b72/attachment.html>
More information about the Plasma-devel
mailing list