Review Request: clean up auto-deletion timeout handling

[Marco Martin]

> On Aug. 6, 2012, 12:33 p.m., Mark Gaiser wrote:
> > 5 minutes fixed in code.. Two possible suggestions.
> > 1. Could you perhaps use the screensaver which probably means that this auto deletion is always done except when the screensaver is running?
> > 2. Use KIdleTime thus always auto delete notifications except when the user is idle. http://api.kde.org/4.8-api/kdelibs-apidocs/kutils/html/classKIdleTime.html
> > 
> > Just a few suggestions :)
> 
> Martin Koller wrote:
>     This patch does not change the handling of the detection of the idle time at all.
>     It is only about a small bugfix and consistency clean up.
>     
>     In fact, the code to detect idle time already uses XScreenSaverQueryInfo

i don't think the screensaver timeout as delete timeout makes much sense there, a fixed timeout if not idle is fine.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105893/#review16967
-----------------------------------------------------------


On Aug. 6, 2012, 11:01 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105893/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 11:01 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> as discussed in private mail, the auto-deletion timer shall only be started from one single place, which is
> the notificationmanager, which starts the timer only if there is user activity on the desktop so that a notification
> which arrives while the user is not at his desk does not get deleted unseen.
> Also, the auto-deletion timeout is reduced to 5 minutes, as I think 20 minutes is much too long (Notifications should only
> provide temporary information for the user for things happening NOW. After some minutes the information is irrelevant).
> For information which is of critical importance, the application can use the urgency=2 which avoids the auto-deletion completely.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/core/notification.cpp 1e1350e 
> 
> Diff: http://git.reviewboard.kde.org/r/105893/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120806/51c11238/attachment.html>