Review Request: clean up auto-deletion timeout handling

[Martin Koller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105893/
-----------------------------------------------------------

(Updated Aug. 6, 2012, 11:01 a.m.)


Review request for Plasma and Marco Martin.


Summary (updated)
-----------------

clean up auto-deletion timeout handling


Description
-------

as discussed in private mail, the auto-deletion timer shall only be started from one single place, which is
the notificationmanager, which starts the timer only if there is user activity on the desktop so that a notification
which arrives while the user is not at his desk does not get deleted unseen.
Also, the auto-deletion timeout is reduced to 5 minutes, as I think 20 minutes is much too long (Notifications should only
provide temporary information for the user for things happening NOW. After some minutes the information is irrelevant).
For information which is of critical importance, the application can use the urgency=2 which avoids the auto-deletion completely.


Diffs
-----

  plasma/generic/applets/notifications/core/notification.cpp 1e1350e 

Diff: http://git.reviewboard.kde.org/r/105893/diff/


Testing
-------


Thanks,

Martin Koller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120806/ef2bf942/attachment-0001.html>