Review Request: fix for: clicking the open button in a completed job notification opened the last file when a complete folder was copied

Martin Koller kollix at aon.at
Fri Aug 3 11:34:47 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105837/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.


Description
-------

When I copy a complete folder, Notifications::finishJob: is called with the last file url, e.g. in my test: KUrl("file:///home/kdetrunk/plop/locale-archive.gz") when copying the "plop" dir.
The CompletedJobNotification object which is created then shows the message created by job->completedMessage() which accounts for the
case when there were more files involved, but the url used in the open action does not handle this case.
This patch creates the url in case of more files as the completedMessage() method does.


This addresses bug 241451.
    http://bugs.kde.org/show_bug.cgi?id=241451


Diffs
-----

  plasma/generic/applets/notifications/core/completedjobnotification.cpp e987a66 

Diff: http://git.reviewboard.kde.org/r/105837/diff/


Testing
-------

single file, complete directory copied.


Thanks,

Martin Koller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120803/0824cf63/attachment.html>


More information about the Plasma-devel mailing list