Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

[Shantanu Tushar Jha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105816/#review16797
-----------------------------------------------------------


Ah, looks much better now! Just some small things to fix and then this can go in :)


browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h
<http://git.reviewboard.kde.org/r/105816/#comment13085>

    This is a better way to do this, a const ref has the primary advantage that you don't create copies
    void error(const QString &message);
    Also make the changes in the definition.



browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.cpp
<http://git.reviewboard.kde.org/r/105816/#comment13086>

    Trailing whitespace, minor, but its nice to remove these :)



components/mediabrowser/MediaItemDelegate.qml
<http://git.reviewboard.kde.org/r/105816/#comment13087>

    Extra whitespaces on 90, 99. Please remove. Also remove them on 183 and 213.



components/mediabrowser/MediaItemDelegate.qml
<http://git.reviewboard.kde.org/r/105816/#comment13088>

    Z override in Image and Rectangle is not needed here. Avoid Z overrides wherever possible, here what you should do instead is move the Rectangle inside the Image so it automagically appears on top of the image.



components/mediabrowser/MediaItemDelegate.qml
<http://git.reviewboard.kde.org/r/105816/#comment13089>

    Remove the console log before pushing


- Shantanu Tushar Jha


On Aug. 2, 2012, 8:29 a.m., Fabian Riethmayer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105816/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2012, 8:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Added slot error(QString) for nepomukmusicmodel. Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h 1ba77e7 
>   browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.cpp d4f7449 
>   components/mediabrowser/MediaItemDelegate.qml bd181ab 
> 
> Diff: http://git.reviewboard.kde.org/r/105816/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> PMC Pictures
>   http://git.reviewboard.kde.org/r/105816/s/660/
> 
> 
> Thanks,
> 
> Fabian Riethmayer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120802/e0e7fd3d/attachment-0001.html>