Review Request: Polishing ScrollBar

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105808/#review16738
-----------------------------------------------------------

Ship it!


the changes are fine, but is probably not enough to completely fix the problem?

- Marco Martin


On Aug. 1, 2012, 1:59 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105808/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 1:59 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch changes two things:
> - When non-interactive or not enabled, don't make the handle responsible of the flickable position.
> - When the Flickable.contentHeight property changes, update the value according to Flickable.contentY. This is important because if both properties are updated at the same time we get in weird states because of RangeModel.
> 
> Also, I'd like this patch to get in for 4.9 (4.9.1 if too late for 4.9.0 :P). It is important because without this KTP's QuickChat Plasmoid is __very__ annoying.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/ScrollBar.qml 430de05 
> 
> Diff: http://git.reviewboard.kde.org/r/105808/diff/
> 
> 
> Testing
> -------
> 
> Played around with http://proli.net/meu/kde/testcase.qml
> Also made sure it fixes my issue in ktp-text-ui
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120801/5feacb59/attachment-0001.html>