Review Request: Merge the branch KLocaleQMLBindings into master

[Sebastian Kügler]

On Sunday, April 29, 2012 20:12:23 Giorgos Tsiapaliwkas wrote:
> > On April 29, 2012, 12:18 p.m., Marco Martin wrote:
> > > yes, i think is to merge at this point.
> > >
> > > 
> > >
> > > it can be only partial, but the api can map to qml only so much, so i
> > > think is as far it can go.> >
> > > 
> > >
> > > to me, the only blocker so far(see below) is that doesn't depend from
> > > plasma at all, so should be in the kde namespace
> You haven't say your opinion about those,
> 
> a. there is tests/contents/code/klocaleqmltest.qml I believe that it should
> be tests/contents/ui/main.qml b. the test plasmoid is exported as
> org.kde.klocaleqmltest it should be org.kde.example.localetest c.
> Locale::setActiveCatalog and Locale::setMainCatalog since we didn't want
> the bindings to influence the core functionality.

Could you put the tests plasmoid under kde-runtime/declarative/tests/ ? That's 
where other test / examples are, so makes it easier to find.

Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9