Review Request: Allow QML items to be associated with operations in Plasma::Service

Alex Merry kde at randomguy3.me.uk
Fri Apr 27 20:47:49 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104760/
-----------------------------------------------------------

(Updated April 27, 2012, 8:47 p.m.)


Review request for Plasma.


Changes
-------

Rename the new methods to associateItem/disassociateItem, since otherwise the scriptengine can't disambiguate when passed a QGraphicsWidget.


Description (updated)
-------

Allow QML items to be associated with operations in Plasma::Service

QML items derive from QGraphicsObject, but not QGraphicsWidget.  We
actually only need QGraphicsObject (for the enabled property).

This allows QML items to be associated with operations (eg: in declarative applets).

The new methods are called (dis)associateItem to prevent disambiguation issues.


Diffs (updated)
-----

  plasma/private/service_p.h 8afef0b6f1ca8bfa11b271fd3b29bc033a94c9a5 
  plasma/service.h 314909ba84702beb16a36208d1a3c058b1a20f77 
  plasma/service.cpp 3846e817d013cf26e2dcf57c5fd86783f061bb13 

Diff: http://git.reviewboard.kde.org/r/104760/diff/


Testing
-------

Tested with a QML plasmoid in plasmoidviewer.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120427/c27b09d7/attachment.html>


More information about the Plasma-devel mailing list