Review Request: Improve PlasmaComponents.ToolButton layout

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104735/#review12925
-----------------------------------------------------------


i agree that looks better here, but i would use thins only for the toolbutton (and not doing a similar thing for pushbuttons)

the reason is in part aestetic (if they are stacked vertically they look better if they have the same width) and in part technical: plasma will try to share the rendered svgs both in memory and in disk cache, so the more elements with exactly the same size there are, the more memory is saved

- Marco Martin


On April 26, 2012, 8:27 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104735/
> -----------------------------------------------------------
> 
> (Updated April 26, 2012, 8:27 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Description
> -------
> 
> This patch fixes two issues in ToolButton layout:
> 
> 1. Make sure there is some space between the button icon and its text
> 
> 2. Do not enforce a minimum width
> 
> The reason for #2 is that having a minimum width does not make much sense for a ToolButton:
> - It should aim at using the minimum amount of horizontal space when used in a ToolBar.
> - It looks unbalanced when used with an icon because the content is flushed to the left, leaving a large amount of white-space on the right. (See attached screenshots)
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 0447a69 
> 
> Diff: http://git.reviewboard.kde.org/r/104735/diff/
> 
> 
> Testing
> -------
> 
> Run attached test script, you should notice the differences in spacing between button icon and text, as well as in the white-space on the right of the button.
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://git.reviewboard.kde.org/r/104735/s/545/
> After
>   http://git.reviewboard.kde.org/r/104735/s/546/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120426/924b3d8c/attachment.html>