Review Request: Add keyboard navigation support to PlasmaComponents.ToolButton

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104727/#review12921
-----------------------------------------------------------


This review has been submitted with commit b10e79a8db422e2d5a1f65149333e4f9f29f10dc by Aurélien Gâteau to branch master.

- Commit Hook


On April 25, 2012, 4:32 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104727/
> -----------------------------------------------------------
> 
> (Updated April 25, 2012, 4:32 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Description
> -------
> 
> ToolButton does not support keyboard navigation. The attached patch fixes this by:
> 
> - Using the "surface" item to indicate focus when the "flat" property is set to true
> 
> - Not giving focus on click if keyboard navigation is not defined. This is a bit tricky, but I figured it would be odd to have a focus border around a button which is part of a toolbar. I could not think of a better way to figure out whether giving focus on click made sense or not.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 9e7e715 
> 
> Diff: http://git.reviewboard.kde.org/r/104727/diff/
> 
> 
> Testing
> -------
> 
> Running attached test script without the patch, "Focusable Button 1" starts focused (this can be seen by pressing "space") but there is no indication that it is. With the patch, an hover frame appears around the focused button. Pressing tab moves the focus to "Focusable Button 2" which gets the hover frame.
> Clicking one of the focusable buttons gives them focus as well, but clicking one of the toolbar buttons does not, since keyboard navigation is not defined for them.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120426/ca4c48b0/attachment.html>