Review Request: Add keyboard navigation support to PlasmaComponents.TextField

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104722/#review12898
-----------------------------------------------------------

Ship it!


good catch

- Marco Martin


On April 25, 2012, 3:24 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104722/
> -----------------------------------------------------------
> 
> (Updated April 25, 2012, 3:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> TextField does not support keyboard navigation. Attached patch fixes this.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/TextField.qml a03ed32 
> 
> Diff: http://git.reviewboard.kde.org/r/104722/diff/
> 
> 
> Testing
> -------
> 
> Run attached textfield-focus-test.qml with qmlviewer. Without the patch, the following bugs can be reproduced:
> - First text field is not focused at startup
> - After clicking first text field, pressing tab does not focus second text field
> - Clicking between the text and the border of the second text field does not focus it
> 
> The patch fixes those issues.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120425/9af1ec4b/attachment.html>