Review Request: Merge the final and fixed QML battery monitor to master.

[Viranch Mehta]

> On April 17, 2012, 11:18 a.m., Kai Uwe Broulik wrote:
> > I just applied it to latest master and found a few usability issues:
> > * The settings dialog that contains all the configs is way too small
> > * The slider "grab" is 10 pixels to the left, some QML component issue
> > And the showstopper issue is:
> > There is no easy way to see the battery percentage. The overlay number is no longer available. And also there is no tooltip, i.e. hovering the plasmoid also does nothing. You _always_ have to click the battery plasmoid to see the exact percentage.
> > The tooltip thing seems to be a general QML plasmoid issue, the new devicec notifier also lacks one.

The patch is not up-to-date. Please checkout the branch plasma/viranch/powermanagementservices and compile plasma/generic/{applets/batterymonitor,dataengines/powermanagement}. That's where all my latest commits have gone.


- Viranch


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review12560
-----------------------------------------------------------


On April 3, 2012, 5:12 a.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> -----------------------------------------------------------
> 
> (Updated April 3, 2012, 5:12 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it to master.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> -------
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> -----------
> 
> with top right graphic in the popup
>   http://git.reviewboard.kde.org/r/104226/s/487/
> applet on the workspace
>   http://git.reviewboard.kde.org/r/104226/s/503/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120417/ce38f2d6/attachment.html>