Review Request: Display of current play time and total media time in plasma media center

[Shantanu Tushar Jha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104613/#review12499
-----------------------------------------------------------

Ship it!


Looks good, fix small issues below and this can go in. Welcome to KDE :)


components/mediacontroller/MediaController.qml
<http://git.reviewboard.kde.org/r/104613/#comment9808>

    check indentation 113-119



shells/newshell/package/contents/ui/mediacenter.qml
<http://git.reviewboard.kde.org/r/104613/#comment9809>

    extra whitespace, remove



shells/newshell/package/contents/ui/mediacenter.qml
<http://git.reviewboard.kde.org/r/104613/#comment9810>

    remove debug output before pushing the code


- Shantanu Tushar Jha


On April 16, 2012, 6:56 a.m., Prashansa Bharti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104613/
> -----------------------------------------------------------
> 
> (Updated April 16, 2012, 6:56 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Added the feature to display current running time and total media time of the currently playing media. The info is displayed in the media controller.
> 
> 
> Diffs
> -----
> 
>   components/mediacontroller/MediaController.qml 3d8ccbe 
>   shells/newshell/package/contents/ui/mediacenter.qml 67106ff 
> 
> Diff: http://git.reviewboard.kde.org/r/104613/diff/
> 
> 
> Testing
> -------
> 
> This feature works fine in trunk.
> 
> 
> Thanks,
> 
> Prashansa Bharti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120416/0835409c/attachment.html>