Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)
Commit Hook
null at kde.org
Sun Apr 15 15:18:48 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104428/#review12476
-----------------------------------------------------------
This review has been submitted with commit f0983fa9a3a1f4466b7d4fa19cfa55914c0cea8a by Makis Marimpis to branch KDE/4.8.
- Commit Hook
On April 12, 2012, 8:23 a.m., makis marimpis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104428/
> -----------------------------------------------------------
>
> (Updated April 12, 2012, 8:23 a.m.)
>
>
> Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić.
>
>
> Description
> -------
>
> (follows discarded review: 104391)
>
> The plugin adds global keyboard shortcuts for changing the activity.
> Defaults start from Qt::MetaModifier + Qt::Key_F1.
>
> Initially, this functionality was implemented (without correct results) using KActitivities::Controller.
> Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds delay - so it really needs modification/and i would like more guidance related to dbus :D.
> Other than that, feedback is needed.
>
>
> This addresses bugs 265069 and 273467.
> http://bugs.kde.org/show_bug.cgi?id=265069
> http://bugs.kde.org/show_bug.cgi?id=273467
>
>
> Diffs
> -----
>
> service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858
> service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION
> service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop PRE-CREATION
> service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION
> service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/104428/diff/
>
>
> Testing
> -------
>
> Logged in.
> Used the default shortcuts to switch activities.
> It works!
>
>
> Thanks,
>
> makis marimpis
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120415/9906ce13/attachment-0001.html>
More information about the Plasma-devel
mailing list