Review Request: Fix KRunner popping up with a white-space character upon pressing Escape key on empty workspace

Kai Uwe Broulik kde at privat.broulik.de
Fri Apr 6 18:23:02 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104497/
-----------------------------------------------------------

(Updated April 6, 2012, 6:23 p.m.)


Review request for Plasma and Vitor Boschi da Silva.


Changes
-------

Check if the character entered is a printable character instead of using a blacklist.


Description
-------

When pressing Escape on an empty workspace, KRunner pops up and is introduced a white-space character, preventing the input from being recognized.
This patch makes KRunner not pop up when pressing the Escape key.


This addresses bug 285350.
    http://bugs.kde.org/show_bug.cgi?id=285350


Diffs (updated)
-----

  plasma/desktop/containments/desktop/desktop.cpp 8bcb877 

Diff: http://git.reviewboard.kde.org/r/104497/diff/


Testing
-------

KRunner does not pop up when pressing Escape key, works fine in other ways.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120406/b0438d52/attachment.html>


More information about the Plasma-devel mailing list