Review Request: Fix QProcess call to start Knotes in LeaveNote applet when KNotes is not running

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104484/#review12180
-----------------------------------------------------------

Ship it!


yeah, a sync wait here is a no go

- Marco Martin


On April 4, 2012, 2:42 p.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104484/
> -----------------------------------------------------------
> 
> (Updated April 4, 2012, 2:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Line 218 in leavenote.cpp knotes.waitForStarted(); is a red herring
> 
> 
> This addresses bug 297415.
>     http://bugs.kde.org/show_bug.cgi?id=297415
> 
> 
> Diffs
> -----
> 
>   applets/leavenote/leavenote.cpp de293e8 
> 
> Diff: http://git.reviewboard.kde.org/r/104484/diff/
> 
> 
> Testing
> -------
> 
> Local testing, patch OKed by thiago on IRC
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120405/181bd2e8/attachment.html>