Review Request: Couple of fixes to QML ScrollBar component

Commit Hook null at kde.org
Wed Apr 4 10:15:35 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104402/#review12156
-----------------------------------------------------------


This review has been submitted with commit 012886da3fa2d4d238646dc684fe352614f19504 by Viranch Mehta to branch master.

- Commit Hook


On March 25, 2012, 2:59 a.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104402/
> -----------------------------------------------------------
> 
> (Updated March 25, 2012, 2:59 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch fixes following issues with QML Scrollbar component:
> 
> - The hover and non-hover arrow images in vertical scrollbars are the same.
> - The down/right arrows are connected to events of mousearea of up/left arrows.
> - The mouseareas of the arrows do not have hoverEnabled property set to true. This is required to use their containsMouse property.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.qml 15ee7aa 
> 
> Diff: http://git.reviewboard.kde.org/r/104402/diff/
> 
> 
> Testing
> -------
> 
> I didn't know how to test these from Gallery.qml (what command?). Tested, however, by putting in a test plasmoid. Works well now.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120404/911f2289/attachment-0001.html>


More information about the Plasma-devel mailing list