Review Request: Merge the final and fixed QML battery monitor to master.

Marco Martin notmart at gmail.com
Tue Apr 3 13:55:17 UTC 2012


On Tuesday 03 April 2012, Viranch Mehta wrote:
> On Tue, Apr 3, 2012 at 1:45 PM, Marco Martin <notmart at gmail.com> wrote:
> > here the biggest challenge i guess is making all resize correctly in
> > horizontal/vertical panels.
> 
> Yes, just spent 5 hours on this. Finally resizing works almost fine inside
> and outside panels, except:
> 
> * it does not resize/change when the orientation of a panel changes (eg,
> top panel is moved to right). i tried
> addEventListener('FormFactorChanged', formFactorChanged); but the callback
> is never called.

argh, looks like this will have to be fixed directly in the appletscript so

> * if the applet is on the desktop, the last visible icon in the list
> flickers _a lot_
> when the applet is resized. this happens for more than one icons visible,
> and
> happens to only the last icon.
> 
> * the c++ applet shows a confirmation box for suspend & hibernate,
> how can this be done in QML? how about showing our regular applet-popup
> like in the battery monitor? with this option, the user also wouldn't have
> to
> move the mouse too much around the screen.

hmm, it should call just the ksmserver dialog, should be added to the service? 
(power? another one?)


-- 
Marco Martin


More information about the Plasma-devel mailing list