Review Request: Merge the final and fixed QML battery monitor to master.

Viranch Mehta viranch.mehta at gmail.com
Tue Apr 3 05:12:00 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
-----------------------------------------------------------

(Updated April 3, 2012, 5:12 a.m.)


Review request for Plasma.


Changes
-------

Add a screenshot of the applet when its in a panel.


Description
-------

I fixed the QML battery monitor to be fairly usable and this diff merges it to master.


Diffs
-----

  plasma/generic/applets/CMakeLists.txt 2dedcb2 
  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
  plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f 

Diff: http://git.reviewboard.kde.org/r/104226/diff/


Testing
-------

Applet and dataengine both tested and work fine.


Screenshots (updated)
-----------

with top right graphic in the popup
  http://git.reviewboard.kde.org/r/104226/s/487/
applet on the workspace
  http://git.reviewboard.kde.org/r/104226/s/503/


Thanks,

Viranch Mehta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120403/2cc05b3b/attachment.html>


More information about the Plasma-devel mailing list