Review Request: Merge the final and fixed QML battery monitor to master.

Viranch Mehta viranch.mehta at gmail.com
Mon Apr 2 14:18:56 UTC 2012



> On April 2, 2012, 12:25 p.m., Sebastian Kügler wrote:
> > Looking good now, thanks a lot for your patience!
> > 
> > I'm getting this TypeError still, haven't looked into the reason behind it:
> > file:///home/sebas/kdesvn/install/share/apps/plasma/plasmoids/battery/contents/ui/batterymonitor.qml:77: TypeError: Result of expression 'pmSource.data["PowerDevil"]' [undefined] is not an object.
> > 
> > I propose to merge it into master now. There's still a bit of polishing possible (margins, for example), but we can easily do those when it's in master.

I'm not getting the TypeError here. About the merge, I have worked on QML lock/logout applet in the same branch. So should I just copy-paste QML battery monitor into master, or cherry-pick from the branch to preserve the history?


- Viranch


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review12114
-----------------------------------------------------------


On March 23, 2012, 6:20 p.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 6:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it to master.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> -------
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> -----------
> 
> with top right graphic in the popup
>   http://git.reviewboard.kde.org/r/104226/s/487/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120402/9d3adae8/attachment.html>


More information about the Plasma-devel mailing list