Review Request: quicklaunch: Add a confirmation dialog before the delete

[Aaron J. Seigo]

> On Sept. 29, 2011, 11:55 a.m., Sebastian Kügler wrote:
> > First, this is the wrong way to fix it. Why should this confirmation only go for a specific widget? This introduces inconsistence in the UI that leads to more data loss (the next time a user deletes a widget, she'll expect there to be a confirmation, and there won't).
> > 
> > Adding a modal dialog is a no-go as well, it blocks the UI and causes general nastiness.
> > 
> > The correct solution against data loss bugs is not to add confirmation dialogs, but to make the action less destructive, for example by adding a way to undo the delete.
> 
> Antonis Tsiapaliokas wrote:
>     When you say "widgets", do you mean only the widgets from the taskmanager or in general (including the desktop)... Because if you mean general, then, do we need to change the kdelibs/plasma???
> 
> Aaron J. Seigo wrote:
>     yes, in general. and yes, it would mean making some changes in libplasma: on deleting an applet, the configuration for the applet would need to be moved to some where else e.g. in to a KConfigGroup within the application's configuration, aka KGlobal::config(). this would move it from -appletsrc and could then be used to create an undo mechanism.

alternatively, this could be stored in an in-memory config object could be used for this (via KConfig(QString(), KConfig::SimpleConfig)) which would mean it wouldn't cause disk i/o or need to be cleared after reboots. it could also be limited in the # of items it stores (or limited to a given amount of time) to keep long-running instances from ever-inflating in size.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102727/#review6906
-----------------------------------------------------------


On Sept. 28, 2011, 8:44 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102727/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2011, 8:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> This patch is adding a new feature to the quicklaunch plasmaoid.
> 
> 
> This addresses bug 270105.
>     http://bugs.kde.org/show_bug.cgi?id=270105
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/quicklaunch/quicklaunch.cpp dfc6125 
> 
> Diff: http://git.reviewboard.kde.org/r/102727/diff/diff
> 
> 
> Testing
> -------
> 
> kde-workspace compiles fine.
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110930/adb203a2/attachment-0001.html>