Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

Aaron J. Seigo aseigo at kde.org
Fri Sep 30 12:39:33 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102732/#review6960
-----------------------------------------------------------



startpage.cpp
<http://git.reviewboard.kde.org/r/102732/#comment6151>

    this should remain, so that opening a project that doesn't have the rc file gets one. best might be to move this code into a method called something like "ensureProjectrcFileExists()" and then call it from both of these places.


- Aaron J. Seigo


On Sept. 29, 2011, 8:51 a.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102732/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 8:51 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> for the moment the .plasmateprojectrc file exists as a mark for the projects created by plasmate.
> We want the file to be created in the creation of the project not in the load of the project,the patch does that.
> 
> cheers
> 
> 
> Diffs
> -----
> 
>   startpage.cpp fc00441 
> 
> Diff: http://git.reviewboard.kde.org/r/102732/diff/diff
> 
> 
> Testing
> -------
> 
> workinig
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110930/bbb76b01/attachment.html>


More information about the Plasma-devel mailing list