Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

[Aaron J. Seigo]

> On Sept. 26, 2011, 12:23 p.m., Aaron J. Seigo wrote:
> > mainwindow.cpp, lines 134-143
> > <http://git.reviewboard.kde.org/r/101916/diff/2/?file=37045#file37045line134>
> >
> >     unecessary change.
> 
> Giorgos Tsiapaliwkas wrote:
>     Aaron in your previous reply you said that the "=0" codes are not needed.
>     What changed?:)

they aren't strictly needed there currently, no. but they don't hurt anything either. i suppose the best thing to do would be to commit this as a seperate commit instead of including it with this change set. it's not critical either way.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101916/#review6828
-----------------------------------------------------------


On Sept. 23, 2011, 4:20 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101916/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 4:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> hello,
> 
> I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed that there wasn't no destructor.
> The patch adds a destructor at projectmanager and changed a bit the mainwindow.cpp.
> 
> I have some question in my next reply
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp 3199f03 
>   previewer/plasmoid/previewcontainment.cpp 7983cdf 
>   previewer/runner/runnerpreviewer.cpp 84c6268 
>   projectmanager/projectmanager.h a99b14f 
>   projectmanager/projectmanager.cpp c9c3797 
>   publisher/publisher.cpp 211b4e6 
>   publisher/signingwidget.h ce40d56 
>   publisher/signingwidget.cpp a4ff7a8 
>   savesystem/branchdialog.cpp c8a2482 
>   sidebar.cpp c9b9318 
> 
> Diff: http://git.reviewboard.kde.org/r/101916/diff/diff
> 
> 
> Testing
> -------
> 
> compiles fine and no pointer error
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110930/dd55eca8/attachment.html>