Review Request: Remove waste setTextBackgroundColor for internal KTextEdit in Plasma::TextEdit widget

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102698/#review6939
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On Sept. 30, 2011, 6:25 a.m., Alexey Chernov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102698/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2011, 6:25 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Removed setTextBackgroundColor() for internal KTextEdit in Plasma::TextEdit widget.
> 
> It seems to be useless as it's voided by inherited QTextDocument as soon as all the contents of the TextEdit is removed (even with Backspace key). The problem is that it also leads to QTBUG-21522 (http://bugreports.qt.nokia.com/browse/QTBUG-21522) which I mentioned in kde-devel mailing-list under 'Plasma::TextEdit problem because of QTextEdit::toHtml() bug' subject. I've sent a patch for that bug, too, but it's probably not good to have any waste functionality in Plasma itself.
> 
> If there were some serious reasons to add this string, please, note them here. Otherwise, I think it's worth to be removed.
> 
> 
> Diffs
> -----
> 
>   plasma/widgets/textedit.cpp 13cc6aa 
> 
> Diff: http://git.reviewboard.kde.org/r/102698/diff/diff
> 
> 
> Testing
> -------
> 
> The behavior is the same when used in plasmoids except mentioned Qt bug isn't reproducible anymore.
> 
> 
> Thanks,
> 
> Alexey Chernov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110930/97c00618/attachment.html>