Review Request: KMenuEdit: Fix disabling 'Only show in KDE'
Aaron J. Seigo
aseigo at kde.org
Mon Sep 26 19:04:27 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102713/#review6846
-----------------------------------------------------------
kmenuedit/basictab.cpp
<http://git.reviewboard.kde.org/r/102713/#comment6087>
according to http://standards.freedesktop.org/menu-spec/latest/ar01s03.html OnlyShowIn is a list of items. so it could be OnlyShowIn=GNOME;KDE
so instead of just deleting the entry, what this should do is read in the entry as a QStringList and then removeAll("KDE") on that list and then write out that as the new value.
- Aaron J. Seigo
On Sept. 26, 2011, 6:42 p.m., Ralf Jung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102713/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2011, 6:42 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This fixes the bug that one could not disable the "Only show in KDE" option for an application in KMenuEdit.
>
>
> This addresses bug 190081.
> http://bugs.kde.org/show_bug.cgi?id=190081
>
>
> Diffs
> -----
>
> kmenuedit/basictab.cpp 4612c2a
>
> Diff: http://git.reviewboard.kde.org/r/102713/diff/diff
>
>
> Testing
> -------
>
> Compiled and logged in to see that the bug is actually fixed.
>
>
> Thanks,
>
> Ralf Jung
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110926/f4a915a9/attachment.html>
More information about the Plasma-devel
mailing list