Review Request: Standard Actions KCM: Hide global column, and fix group name

Ralf Jung ralfjung-e at gmx.de
Mon Sep 26 15:50:55 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102709/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

This patch attempts to fix https://bugs.kde.org/show_bug.cgi?id=245603 . It also fixes the problem that the action group had the title "Unknown" by setting it manually.
The same string also appears at the beginning of StandardActionsModule::StandardActionsModule - does that mean it can be backported?

I hope I added the right people as reviewers... I could not find a kde-workspace group and was told in IRC that plasma mostly deals with that.


This addresses bug 245603.
    http://bugs.kde.org/show_bug.cgi?id=245603


Diffs
-----

  kcontrol/standard_actions/standard_actions_module.cpp f1bd45d 

Diff: http://git.reviewboard.kde.org/r/102709/diff/diff


Testing
-------

Compile-tested, logged in and verified that the column indeed disappeared and the group name was fixed.


Thanks,

Ralf Jung

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110926/8e001188/attachment.html>


More information about the Plasma-devel mailing list