Review Request: kde-runtime:fix the coding style of plasmacomponents

Aaron J. Seigo aseigo at kde.org
Mon Sep 26 12:19:04 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102684/#review6827
-----------------------------------------------------------


other than the other error found (which introduces a subtle bug :), there is one whitespace issue i noticed. once both are fixed, this can be committed... cheers :)


plasma/declarativeimports/plasmacomponents/qml/ScrollBar.qml
<http://git.reviewboard.kde.org/r/102684/#comment6081>

    should be on the same line: } else {


- Aaron J. Seigo


On Sept. 23, 2011, 5:59 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102684/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 5:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> at kde-runtime/plasma/declarativeimports/plasmacomponents the coding style is not the plasma one.
> This patch fixes the coding style.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/Button.qml 48bb717 
>   plasma/declarativeimports/plasmacomponents/qml/ButtonGroup.js ea8ca74 
>   plasma/declarativeimports/plasmacomponents/qml/Highlight.qml 9670c28 
>   plasma/declarativeimports/plasmacomponents/qml/ScrollBar.qml 8adc8b6 
>   plasma/declarativeimports/plasmacomponents/qml/ScrollDecorator.qml 5ef6638 
>   plasma/declarativeimports/plasmacomponents/qml/Slider.qml 1931abf 
>   plasma/declarativeimports/plasmacomponents/qml/TextArea.qml f3a7a34 
>   plasma/declarativeimports/plasmacomponents/qml/TextField.qml beaa681 
> 
> Diff: http://git.reviewboard.kde.org/r/102684/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110926/bfc80dde/attachment-0001.html>


More information about the Plasma-devel mailing list