Review Request: do not split the year in the clock tip
Jaime Torres Amate
jtamate at gmail.com
Thu Sep 15 15:40:27 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102621/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
The first version of this patch only:
* allows Qt to split the date in the spaces, avoiding the split in the year.
* removes a <table> that makes the rendering harder
* adds a <br> to include an space between the dates and the event.
The second verion of this patch does:
* changes the table to show the city and time in one line and the date, in another line, always complete.
* removes a <table> that makes the rendering harder
* adds a <br> to include an space between the dates and the event.
Look at the screnshot.
Can remove the <br>, leave it, or add another before the table of cities.
This addresses bug 260394.
http://bugs.kde.org/show_bug.cgi?id=260394
Diffs
-----
libs/plasmaclock/clockapplet.cpp b1275af
Diff: http://git.reviewboard.kde.org/r/102621/diff
Testing
-------
Checked with zero, one and several timezones with short and large city names in two machines.
Screenshots
-----------
version 2
http://git.reviewboard.kde.org/r/102621/s/262/
Thanks,
Jaime Torres
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110915/edf7f289/attachment.html>
More information about the Plasma-devel
mailing list