Review Request: picture frame widget - move to next picture on delete

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103001/#review7771
-----------------------------------------------------------


personally, what i'd do in SlideShow::pictureLoaded is this:

if (image.isNull()) {
     m_picturePaths.removeAt(m_slideNumber);
     setUrl(0);
     return;
}
    
i've done this an a bit more as a result of your patch.. thanks :)


applets/frame/slideshow.cpp
<http://git.reviewboard.kde.org/r/103001/#comment6655>

    should be on the same line: } else {


- Aaron J. Seigo


On Oct. 30, 2011, 9:59 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103001/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2011, 9:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Now when you delete in slideshow mode a picture (right click, open picture, delete), the frame widget moves on to the next picture without complaining. Possibly my implementation is stupid.
> 
> 
> This addresses bug 177212.
>     http://bugs.kde.org/show_bug.cgi?id=177212
> 
> 
> Diffs
> -----
> 
>   applets/frame/picture.h 7fc33b4 
>   applets/frame/picture.cpp 57d82ed 
>   applets/frame/slideshow.cpp a461244 
> 
> Diff: http://git.reviewboard.kde.org/r/103001/diff/diff
> 
> 
> Testing
> -------
> 
> it compiles
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111031/a64acd73/attachment.html>