Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

David Narváez david.narvaez at computer.org
Mon Oct 31 06:57:23 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102997/
-----------------------------------------------------------

(Updated Oct. 31, 2011, 6:57 a.m.)


Review request for Plasma and Sergio Luis Martins.


Changes
-------

Had to modify the last chunk, the original one didn't compile. On working on this, I noticed the notifyIncidenceChanged method had a deprecation notice that appeared many commits ago and no explanation of what should be used now, so I'd like to read opinions on what do do there. I'll be investigating too.


Description
-------

Adjust KDateTimes after finding out the type of incidence added. Also adjust KDateTimes after a change in the Calendar TimeSpec.


This addresses bug 279427.
    http://bugs.kde.org/show_bug.cgi?id=279427


Diffs (updated)
-----

  plasma/generic/dataengines/calendar/akonadi/calendar.cpp cd96954 

Diff: http://git.reviewboard.kde.org/r/102997/diff/diff


Testing
-------

1. Add an event in any timezone distinct from the local timezone (you can do that in KOrganizer)
2. Check the start and end times of the event in the calendar

Not sure how to test changing timezones from Plasma, so proposed patch is based on what I think we should do in such a case.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111031/ec9cbb14/attachment.html>


More information about the Plasma-devel mailing list