Review Request: picture frame widget - open potd picture

[Mark]

On Fri, Oct 28, 2011 at 5:05 PM, Commit Hook <null at kde.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102817/
>
> This review has been submitted with commit c0360bc3ba5e6b049a6605309dcfc4e78d1b0675 by Aaron Seigo to branch master.
>
>
> - Commit
>
> On October 28th, 2011, 10:20 a.m., Greg T wrote:
>   Review request for Plasma.
> By Greg T.
>
> *Updated Oct. 28, 2011, 10:20 a.m.*
> Description
>
> Hi,
> This fix passes m_currentUrl the correct file path, so the downloaded picture will be opened by the picture viewer (gwenview).
>
>   Testing
>
> Bug fixed.
>
>   *Bugs: * 280406 <http://bugs.kde.org/show_bug.cgi?id=280406>
> Diffs
>
>    - applets/frame/slideshow.cpp (116c514)
>    - dataengines/potd/potd.cpp (f1b9933)
>
> View Diff <http://git.reviewboard.kde.org/r/102817/diff/>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
/home/kde-devel/kdesrc/kde/kdeplasma-addons/wallpapers/potd/potd.cpp: In
member function ‘void PoTD::dataUpdated(const QString&, const Data&)’:
/home/kde-devel/kdesrc/kde/kdeplasma-addons/wallpapers/potd/potd.cpp:71:53:
error: no matching function for call to ‘PoTD::render(QImage&, QSize)’
/home/kde-devel/kdesrc/kde/kdeplasma-addons/wallpapers/potd/potd.cpp:71:53:
note: candidate is:
/home/kde-devel/kde/include/KDE/Plasma/../../plasma/wallpaper.h:485:14:
note: void Plasma::Wallpaper::render(const QString&, const QSize&,
Plasma::Wallpaper::ResizeMethod, const QColor&)
/home/kde-devel/kde/include/KDE/Plasma/../../plasma/wallpaper.h:485:14:
note:   no known conversion for argument 1 from ‘QImage’ to ‘const QString&’

Seems like a few tiny bugs ;)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111030/55fc6ca4/attachment.html>